[webkit-reviews] review denied: [Bug 93496] [BlackBerry] Add RSS content handling support : [Attachment 159465] patch for 93496.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 20 10:31:07 PDT 2012
Rob Buis <rwlbuis at gmail.com> has denied review:
Bug 93496: [BlackBerry] Add RSS content handling support
https://bugs.webkit.org/show_bug.cgi?id=93496
Attachment 159465: patch for 93496.
https://bugs.webkit.org/attachment.cgi?id=159465&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159465&action=review
Some minor issues so far and you need a ChangeLog.
> Source/WebCore/platform/network/blackberry/rss/RSSGenerator.h:22
> +#include <wtf/text/WTFString.h>
It does not seem like you need this include.
> Source/WebCore/platform/network/blackberry/rss/RSSParserBase.cpp:113
> + WTF::String text;
You do not need this WTF:: prefix for String.
More information about the webkit-reviews
mailing list