[webkit-reviews] review granted: [Bug 90597] Web Inspector: [WebGL] Generic framework draft for tracking WebGL resources : [Attachment 159434] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 20 09:37:18 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 90597: Web Inspector: [WebGL] Generic framework draft for tracking WebGL
resources
https://bugs.webkit.org/show_bug.cgi?id=90597

Attachment 159434: Patch
https://bugs.webkit.org/attachment.cgi?id=159434&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159434&action=review


> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:164
> +};

drop the ; from all over the place plz.

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:369
> +    captureResource: function(resource)

Missing annotations.

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:374
> +    addCall: function(call)

Missing annotations.


More information about the webkit-reviews mailing list