[webkit-reviews] review granted: [Bug 94419] Clean up SVGLocatable inheritance : [Attachment 159333] Remove incorrect getBBox() code
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 20 09:04:30 PDT 2012
Dirk Schulze <krit at webkit.org> has granted Philip Rogers <pdr at google.com>'s
request for review:
Bug 94419: Clean up SVGLocatable inheritance
https://bugs.webkit.org/show_bug.cgi?id=94419
Attachment 159333: Remove incorrect getBBox() code
https://bugs.webkit.org/attachment.cgi?id=159333&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159333&action=review
r=me, but...
> Source/WebCore/ChangeLog:9
> + SVGPathElement defines a getBBox() function that is both wrong and
> + deadcode. This patch cleans this up.
I would agree that we should return objectBoundingBox(), but is does not seem
to be "deadcode". Can you change this comment please?
More information about the webkit-reviews
mailing list