[webkit-reviews] review granted: [Bug 94482] [BlackBerry] Persist cookies not from atexit() but the new onThreadFinished() : [Attachment 159428] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 20 08:32:13 PDT 2012


Yong Li <yoli at rim.com> has granted Jakob Petsovits <jpetsovits at rim.com>'s
request for review:
Bug 94482: [BlackBerry] Persist cookies not from atexit() but the new
onThreadFinished()
https://bugs.webkit.org/show_bug.cgi?id=94482

Attachment 159428: Patch
https://bugs.webkit.org/attachment.cgi?id=159428&action=review

------- Additional Comments from Yong Li <yoli at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159428&action=review


> Source/WebCore/ChangeLog:9
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   No new functionality, no new tests.

need some description between these 2 lines :)

>
Source/WebCore/platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBac
kingStore.cpp:89
> +    CookieLog("CookieManager - flushing cookies to backingStore...");

should be cookieLog() according to webkit style?


More information about the webkit-reviews mailing list