[webkit-reviews] review granted: [Bug 93862] Text Autosizing: Only take into account block width <= document layout width. : [Attachment 159427] Patch

Mon Aug 20 08:01:59 PDT 2012

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted John Mellor
<johnme at chromium.org>'s request for review:
Bug 93862: Text Autosizing: Only take into account block width <= document
layout width.
https://bugs.webkit.org/show_bug.cgi?id=93862

Attachment 159427: Patch
https://bugs.webkit.org/attachment.cgi?id=159427&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159427&action=review

> Source/WebCore/ChangeLog:13
> +	   Instead of calculating the textAutosizingMultiplier purely based on
the
> +	   width of each block, we now work out the maximum width of the block
> +	   that could be displayed onscreen at any one time, and use that
value.
> +	   This avoids excessive text size multiplication (there's no point
making
> +	   text bigger than this, since you wouldn't be able to zoom out far
> +	   enough to read it!).

Should we consider the viewport meta maximum-scale ?

> LayoutTests/fast/text-autosizing/narrow-iframe-flattened.html:1
> +<html>

I think we are supposed to add the html doctype <!DOCTYPE html>