[webkit-reviews] review granted: [Bug 94471] [GTK] Replace webkit_web_view_replace_content with webkit_web_view_load_alternate_html : [Attachment 159403] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 20 07:22:13 PDT 2012


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 94471: [GTK] Replace webkit_web_view_replace_content with
webkit_web_view_load_alternate_html
https://bugs.webkit.org/show_bug.cgi?id=94471

Attachment 159403: Patch
https://bugs.webkit.org/attachment.cgi?id=159403&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159403&action=review


Thanks!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1554
> + * error page, the the back-forward list is maintained appropriately.

Hrm. Would it make sense to just say outright something like, "When this method
is called, a new entry is added to the back-forward list." ?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1555
> + * For everything else this method works the same way than
webkit_web_view_load_html().

Nit: same way than -> same way as


More information about the webkit-reviews mailing list