[webkit-reviews] review canceled: [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON : [Attachment 159127] Fixes the bug

[bugzilla-daemon at webkit.org]

Alejandro Piñeiro <apinheiro at igalia.com> has canceled Alejandro Piñeiro
<apinheiro at igalia.com>'s request for review:
Bug 73819: [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not
ROLE_PUSH_BUTTON
https://bugs.webkit.org/show_bug.cgi?id=73819

Attachment 159127: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=159127&action=review

------- Additional Comments from Alejandro Piñeiro <apinheiro at igalia.com>
This last update adds chromium platform specifics. I didn't add it on the
previous one because I only searched platform specific code on WebCore, as with
gtk and mac, but it seems that most specific accessibility related code for
chromium resides at WebKit level.

As with mac, I tried to make a ToggleButton->Button role matching, but I was
not able to do that. This is because chromium WebAccessibilityRole needs to be
a perfect 1-to-1 match with WebCore AccessibilityRole. In fact, at
WebAccessibilityObject::roleValue, the matching rule is a static_cast of the
AccessibilityObject wrapped.

So in the end I needed to add a new WebAccessibilityRole,
WebAccessibilityRoleToggleButton. I also needed to update
AccessibilityUIElementChromium in order to print the proper role name.