[webkit-reviews] review denied: [Bug 94423] Web Inspector: prepare scripts panel to be lazily loaded : [Attachment 159293] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 94423: Web Inspector: prepare scripts panel to be lazily loaded
https://bugs.webkit.org/show_bug.cgi?id=94423

Attachment 159293: Patch
https://bugs.webkit.org/attachment.cgi?id=159293&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159293&action=review


Scipts panel should check if debugger is paused on creation.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:313
> +	       if (!(uiSourceCodes[i] instanceof
WebInspector.JavaScriptSource))

Looks like a hack. I don't think this will work correctly with snippets.