[webkit-reviews] review canceled: [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface : [Attachment 159079] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 19 23:44:02 PDT 2012


KwangYong Choi <ky0.choi at samsung.com> has canceled KwangYong Choi
<ky0.choi at samsung.com>'s request for review:
Bug 91832: [EFL][WK2] Implemented color chooser proxy and input picker
interface
https://bugs.webkit.org/show_bug.cgi?id=91832

Attachment 159079: Patch
https://bugs.webkit.org/attachment.cgi?id=159079&action=review

------- Additional Comments from KwangYong Choi <ky0.choi at samsung.com>
1. Removed virtual keyword.

2. Added "EINA_SAFETY_ON_NULL_RETURN(priv->colorChooser);" in
ewk_view_color_chooser_hide_request().

3. Test is implemented.


More information about the webkit-reviews mailing list