[webkit-reviews] review granted: [Bug 94443] [V8] Move V8Proxy::newInstance() to V8ObjectConstructor : [Attachment 159332] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 94443: [V8] Move V8Proxy::newInstance() to V8ObjectConstructor
https://bugs.webkit.org/show_bug.cgi?id=94443

Attachment 159332: Patch
https://bugs.webkit.org/attachment.cgi?id=159332&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159332&action=review


> Source/WebCore/bindings/v8/V8Binding.cpp:384
> +void assertIfV8IsDead()

assertIfV8IsDead -> crashIfV8IsDead

This happens in release too, so it shouldn't say "alert"

> Source/WebCore/bindings/v8/V8ObjectConstructor.cpp:71
> +v8::Local<v8::Object>
V8ObjectConstructor::newInstanceInFrame(v8::Handle<v8::Function> function, int
argc, v8::Handle<v8::Value> argv[], Frame* frame)

Can we pass in a Document rather than a Frame here?  Using a Frame for a
context object isn't correct.