[webkit-reviews] review granted: [Bug 93941] [Forms] Set SpinButtonElement free from HTMLInputElement : [Attachment 159064] Patch 3

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted yosin at chromium.org's request for
review:
Bug 93941: [Forms] Set SpinButtonElement free from HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=93941

Attachment 159064: Patch 3
https://bugs.webkit.org/attachment.cgi?id=159064&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159064&action=review


> Source/WebCore/ChangeLog:40
> +	   * html/TextFieldInputType.cpp:
> +	   (WebCore::TextFieldInputType::focusAndSelectSpinButtonOwner):
> +	   (WebCore::TextFieldInputType::shouldSpinButtonRespondToMouseEvents):

> +	   (WebCore::TextFieldInputType::shouldSpinButtonRespondToWheelEvents):

> +	   * html/TextFieldInputType.h:
> +	   (TextFieldInputType):
> +	   * html/TimeInputType.cpp:
> +	  
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::focusAndSelectEditContro
lOwner):
> +	  
(WebCore::TimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerFocuse
d):
> +	   * html/TimeInputType.h:
> +	   (DateTimeEditControlOwnerImpl):
> +	   * html/shadow/DateTimeEditElement.cpp:
> +	   (WebCore::DateTimeEditElement::focusAndSelectSpinButtonOwner):
> +	  
(WebCore::DateTimeEditElement::shouldSpinButtonRespondToMouseEvents):
> +	  
(WebCore::DateTimeEditElement::shouldSpinButtonRespondToWheelEvents):
> +	   * html/shadow/DateTimeEditElement.h:
> +	   (EditControlOwner):
> +	   (DateTimeEditElement):
> +	   * html/shadow/SpinButtonElement.cpp:
> +	   (WebCore::SpinButtonElement::defaultEventHandler):
> +	   (WebCore::SpinButtonElement::forwardEvent):
> +	   (WebCore::SpinButtonElement::willRespondToMouseMoveEvents):
> +	   (WebCore::SpinButtonElement::willRespondToMouseClickEvents):
> +	   (WebCore::SpinButtonElement::step):
> +	   (WebCore::SpinButtonElement::shouldRespondToMouseEvents):
> +	   * html/shadow/SpinButtonElement.h:
> +	   (SpinButtonOwner):
> +	   (SpinButtonElement):

You had better add per-function comments, especially to existing functions.