[webkit-reviews] review denied: [Bug 93290] getBBox() returns (0, 0) when width or height is zero. : [Attachment 159282] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Changhun Kang
<temoochin at company100.net>'s request for review:
Bug 93290: getBBox() returns (0,0) when width or height is zero.
https://bugs.webkit.org/show_bug.cgi?id=93290

Attachment 159282: Patch
https://bugs.webkit.org/attachment.cgi?id=159282&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159282&action=review


The patch looks good in general, i wonder about the term "is in error" .
Currently you just disable rendering for zero and negative case. A test with
negative width/height/r/rx/ry would be great as well.

> Source/WebCore/rendering/svg/RenderSVGEllipse.cpp:74
> +    bool renderable = m_radii.width() && m_radii.height();

No extra variable needed, you just call it once.

> Source/WebCore/rendering/svg/RenderSVGRect.cpp:81
> +    bool renderable = boundingBoxSize.width() && boundingBoxSize.height();

Ditto.