[webkit-reviews] review denied: [Bug 94392] [chromium] Put webkit compositor binding files in separate conditionally included gyp section : [Attachment 159239] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 17:34:24 PDT 2012


Dirk Pranke <dpranke at chromium.org> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 94392: [chromium] Put webkit compositor binding files in separate
conditionally included gyp section
https://bugs.webkit.org/show_bug.cgi?id=94392

Attachment 159239: Patch
https://bugs.webkit.org/attachment.cgi?id=159239&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159239&action=review


dunno what the "standard practice" is ...

> Source/WebKit/chromium/WebKit.gyp:841
> +			   'webkit_compositor_bindings_files',

think this needs to be <@(webkit_compositor_bindings_files)


More information about the webkit-reviews mailing list