[webkit-reviews] review granted: [Bug 93420] Track -webkit property usage. : [Attachment 159216] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tab Atkins <tabatkins at google.com>'s
request for review:
Bug 93420: Track -webkit property usage.
https://bugs.webkit.org/show_bug.cgi?id=93420

Attachment 159216: Patch
https://bugs.webkit.org/attachment.cgi?id=159216&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159216&action=review


Seems fine to me. This of course will only catch uses in stylesheets. It won't
catch prefixed properties being modified from JS (i.e. via node.style.WebKit*).
That's fine for an initial pass, but probably isn't enough to confidently start
killing prefixed property names.

Also, all the prefixed properties in the useragent stylesheet (html.css) will
hit on every page.

I'm actually not sure how you'd go about restricting to one entry per document.
You'd need to keep a hashtable of which entries we've seen so far, and I don't
think we'd want to do that. Hm...I suppose you could just keep bitset of bool
since there's ~400 ids. Not sure this even warrants 50 bytes per document
though. Either way, that can be a follow-up decision once we have an initial
dataset.

> Source/WebCore/css/CSSParser.cpp:10127
> +    if (hasPrefix(buffer, length, "-webkit-"))

We should watch the perf bots after this lands to be sure this doesn't affect
performance.