[webkit-reviews] review granted: [Bug 94319] [CMake] Add FindDBus.cmake and use it in the EFL port. : [Attachment 159056] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 11:58:19 PDT 2012


Daniel Bates <dbates at webkit.org> has granted Raphael Kubo da Costa (rakuco)
<rakuco at webkit.org>'s request for review:
Bug 94319: [CMake] Add FindDBus.cmake and use it in the EFL port.
https://bugs.webkit.org/show_bug.cgi?id=94319

Attachment 159056: Patch
https://bugs.webkit.org/attachment.cgi?id=159056&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159056&action=review


r=me

> ChangeLog:15
> +	   Once we properly detect the EFL without pkg-config, that's going
> +	   to break, so write a FindDBus.cmake to avoid that problem in the
> +	   future.

This sentence doesn't read well.


More information about the webkit-reviews mailing list