[webkit-reviews] review granted: [Bug 91660] Text Autosizing: Increase line height in proportion to font size. : [Attachment 159135] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted John Mellor
<johnme at chromium.org>'s request for review:
Bug 91660: Text Autosizing: Increase line height in proportion to font size.
https://bugs.webkit.org/show_bug.cgi?id=91660

Attachment 159135: Patch
https://bugs.webkit.org/attachment.cgi?id=159135&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159135&action=review


r=me. Let's see if it builds on all platforms before cq+ it.

> LayoutTests/fast/text-autosizing/em-margin-border-padding.html:15
> +    console.warn("This test depends on the Text Autosizing setting being
true, so run it in DumpRenderTree, or manually enable Text Autosizing, and
either use a mobile device with 320px device-width (like Nexus S or iPhone), or
define HACK_FORCE_TEXT_AUTOSIZING_ON_DESKTOP.");

> I could add a flag to about:flags for testing it in Chromium at least. Would
that be useful, or can you think of a more general way of making it available?

Mhh, I don't have a good answer. A runtime flag would enable us to expose it
for sure but it has its downsides. Let's go with that comment and file a
follow-up bug as it is an open problem.