[webkit-reviews] review granted: [Bug 94329] [BlackBerry] Adapt to changes in the platform media player API : [Attachment 159094] patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Robin Cao
<robin.cao at torchmobile.com.cn>'s request for review:
Bug 94329: [BlackBerry] Adapt to changes in the platform media player API
https://bugs.webkit.org/show_bug.cgi?id=94329

Attachment 159094: patch
https://bugs.webkit.org/attachment.cgi?id=159094&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159094&action=review


>>>
Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:17
5
>>> +	     m_platformPlayer->cancelLoad();
>> 
>> I think this and all the other null checks are changes in the behavior. Why
is that needed now?
> 
> Because m_platformPlayer is allocated in load rather than in the constructor?


Very reasonable.