[webkit-reviews] review requested: [Bug 94237] iframe does not stretch in flexbox : [Attachment 159147] Patch

[bugzilla-daemon at webkit.org]

Shezan Baig <shezbaig.wk at gmail.com> has asked  for review:
Bug 94237: iframe does not stretch in flexbox
https://bugs.webkit.org/show_bug.cgi?id=94237

Attachment 159147: Patch
https://bugs.webkit.org/attachment.cgi?id=159147&action=review

------- Additional Comments from Shezan Baig <shezbaig.wk at gmail.com>
There were two ways to fix this:

1) Make RenderBox::computeLogicalWidth and computeLogicalHeight take
RenderFlexibleBox parents into consideration (in similar way that it takes the
deprecated flexBox into consideration), or

2) Make RenderFlexibleBox always set the override width/height on the child if
the child computes its size as a replaced element.

I went with option (2) in order to avoid the dependency from RenderBox to
RenderFlexibleBox.  I also extended the test case to include vertically flowing
flexboxes.