[webkit-reviews] review requested: [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON : [Attachment 159127] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 08:15:49 PDT 2012


Alejandro Piñeiro <apinheiro at igalia.com> has asked  for review:
Bug 73819: [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not
ROLE_PUSH_BUTTON
https://bugs.webkit.org/show_bug.cgi?id=73819

Attachment 159127: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=159127&action=review

------- Additional Comments from Alejandro Piñeiro <apinheiro at igalia.com>
Updated patch based on the last comments. It adds a new role to WebCore:
ToggleButtonRole. On gtk platform the mapping is
ToggleButtonRole->ATK_ROLE_TOGGLE_BUTTON. On mac platform the mapping is
ToggleButtonRole->NSAccessibilityButtonRole. The rest of the platforms doesn't
have any role mapping.


More information about the webkit-reviews mailing list