[webkit-reviews] review granted: [Bug 94101] Touch adjustment for context menu gestures : [Attachment 159067] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 17 06:48:46 PDT 2012
Antonio Gomes <tonikitoo at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at nokia.com>'s request for review:
Bug 94101: Touch adjustment for context menu gestures
https://bugs.webkit.org/show_bug.cgi?id=94101
Attachment 159067: Patch
https://bugs.webkit.org/attachment.cgi?id=159067&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159067&action=review
Lets get the namings discussed here changed.
> Source/WebCore/page/TouchAdjustment.cpp:91
> +bool nodeProvidesContextMenuItems(Node* node)
I think we can exclude "node" from the beginning, since the parameter is a
'node'.
> Source/WebCore/page/TouchAdjustment.cpp:105
> + // FIXME: To improve the adjusted point, each individual word should
be a separate subtarget.
See FatFingers.
More information about the webkit-reviews
mailing list