[webkit-reviews] review denied: [Bug 93443] Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event : [Attachment 158311] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrei Poenaru
<poenaru at adobe.com>'s request for review:
Bug 93443: Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
https://bugs.webkit.org/show_bug.cgi?id=93443

Attachment 158311: Patch
https://bugs.webkit.org/attachment.cgi?id=158311&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158311&action=review


> Source/WebCore/inspector/InspectorCSSAgent.cpp:838
> +    if (!m_namedFlowCollectionsRequested.contains(documentNodeId)) {

I think m_namedFlowCollectionsRequested is superflous now that you have the
more complete m_documentIdToNamedFlowSetMap.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:868
> +	       it = m_documentIdToNamedFlowSetMap.add(documentNodeId,
NamedFlowSet()).iterator;

You should register this flow in the m_documentIdToNamedFlowSetMap from
getNamedFlowCollection as well. I think it is better to do that in
buildObjectForNamedFlow. You collection tracks elements that are sent to the
front-end and the buildObjectForNamedFlow is a perfect place to do that.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:1162
> +    int documentNodeId = m_domAgent->boundNodeId(document);

Looks like too much copypaste (add the "remove" parameter to the original
method? reuse same implementation?)