[webkit-reviews] review denied: [Bug 91528] Web Inspector: Embeddable Web Inspector : [Attachment 158871] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 17 04:40:43 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has denied Gabriel Peal
<gpeal at google.com>'s request for review:
Bug 91528: Web Inspector: Embeddable Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=91528
Attachment 158871: Patch
https://bugs.webkit.org/attachment.cgi?id=158871&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158871&action=review
> Source/WebCore/ChangeLog:10
> + TBD
Nuke this line.
> Source/WebCore/inspector/front-end/InspectorFrontendAPI.js:148
> + WebInspector.panels.timeline.loadFromURL(url);
You should now to WebInspector.showPanel("timeline").loadFromURL(url) instead
of these two lines.
> Source/WebCore/inspector/front-end/TimelineModel.js:254
> + function onDataReceived(data)
Is this function used?
> Source/WebCore/inspector/front-end/TimelineModel.js:273
> + function onLoad(responseText)
This does not need to be a function.
> Source/WebCore/inspector/front-end/TimelinePanel.js:372
> + this.toggleTimelineButton.toggled = false;
You probably want to call _toggleTimelineButtonClicked here to reduce
copypaste.
> Source/WebCore/inspector/front-end/utilities.js:732
> + * @param {function(string)=} callback
function(?string)=
> Source/WebCore/inspector/front-end/utilities.js:733
> + * @return {string}
?string
More information about the webkit-reviews
mailing list