[webkit-reviews] review granted: [Bug 93971] [V8] Refactor away IsolatedWorld : [Attachment 159059] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 02:49:27 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Dan Carney
<dcarney at google.com>'s request for review:
Bug 93971: [V8] Refactor away IsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=93971

Attachment 159059: Patch
https://bugs.webkit.org/attachment.cgi?id=159059&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
Looks OK.

By the way, do you have a plan to rename DOMWrapperWorld to IsolatedWorld? (You
can do it in a follow-up patch.) A bunch of method names and variable names are
using "isolatedWorld". In particular, some Chromium API names (e.g.
evaluateInIsolatedWorld()) are using "IsolatedWorld", and it is difficult to
rename Chromium APIs. So I think that it would be reasonable to rename
DOMWrapperWorld to IsolatedWorld.


More information about the webkit-reviews mailing list