[webkit-reviews] review granted: [Bug 94308] [EFL][WK2] Getting unnecessary EINA_SAFETY_ON_NULL_RETURN_VAL warnings while page navigation : [Attachment 159035] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 17 01:23:22 PDT 2012
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 94308: [EFL][WK2] Getting unnecessary EINA_SAFETY_ON_NULL_RETURN_VAL
warnings while page navigation
https://bugs.webkit.org/show_bug.cgi?id=94308
Attachment 159035: patch
https://bugs.webkit.org/attachment.cgi?id=159035&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=159035&action=review
> Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.cpp:132
> - addItemToWrapperCache(list, wkAddedItem); // Puts new item to the cache.
> + if (wkAddedItem)
> + addItemToWrapperCache(list, wkAddedItem); // Puts new item to the
cache.
A comment in the code makes sense
More information about the webkit-reviews
mailing list