[webkit-reviews] review denied: [Bug 91704] ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception. : [Attachment 159025] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 00:48:00 PDT 2012


Hajime Morrita <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 91704: ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=91704

Attachment 159025: Patch
https://bugs.webkit.org/attachment.cgi?id=159025&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=159025&action=review


> LayoutTests/fast/dom/shadow/shadowroot-clonenode.html:6
> +<script>

Needs description() here.

> LayoutTests/fast/dom/shadow/shadowroot-clonenode.html:17
> +var successfullyParsed = true

finishJSTest() instead of "successfullyParsed = true" is the latest trend.


More information about the webkit-reviews mailing list