[webkit-reviews] review granted: [Bug 94271] Introduce a will-be-removed-from-tree notification in RenderObject : [Attachment 158956] Proposed implementation 1, welcome any comment on the naming.

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 94271: Introduce a will-be-removed-from-tree notification in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=94271

Attachment 158956: Proposed implementation 1, welcome any comment on the
naming.
https://bugs.webkit.org/attachment.cgi?id=158956&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158956&action=review


We should make that notifyRenderer change as Elliot said in last comment. This
matches http://trac.webkit.org/changeset/125737.

> Source/WebCore/rendering/RenderObject.cpp:2416
> +	   if (isBox())

Can this if be moved to RenderBox::willBeRemovedFromTree ? I suspect the
ordering of the regions calls here will cause problem. Lets cc mihnea at adobe.com
to confirm.