[webkit-reviews] review granted: [Bug 94262] Delete some dead code in RenderBox::computePercentageLogicalHeight : [Attachment 158940] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 94262: Delete some dead code in RenderBox::computePercentageLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=94262

Attachment 158940: Patch
https://bugs.webkit.org/attachment.cgi?id=158940&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158940&action=review


>>> Source/WebCore/ChangeLog:9
>>> +	     including the ones added in the original patch
http://trac.webkit.org/changeset/10983.
>> 
>> Do we not hit this code because we hit an earlier case that does the same
thing?
> 
> No. The cases where we might in theory hit this code, we instead go through
computePositionedLogicalHeight (i.e. never call
computePercentageLogicalHeight).

I would include this explanation in the ChangeLog.  Would also be good to say
which test covers this.