[webkit-reviews] review granted: [Bug 94264] Heap::setActivityCallback leaks the old GCActivityCallback : [Attachment 158946] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 94264: Heap::setActivityCallback leaks the old GCActivityCallback
https://bugs.webkit.org/show_bug.cgi?id=94264

Attachment 158946: Patch
https://bugs.webkit.org/attachment.cgi?id=158946&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
This fix is OK.

In the long run, I'd prefer a less whacky ownership model: Put the callback in
a smart pointer, have its destructor lock the shutdown mutex and invalidate and
unschedule its timer, and have timerDidFire lock the shutdown mutex and
double-check that the timer is still valid.