[webkit-reviews] review requested: [Bug 94255] Add AV perf layout tests to webkit flakiness dashboard : [Attachment 158911] Patch

[bugzilla-daemon at webkit.org]

Shadi <shadi at chromium.org> has asked  for review:
Bug 94255: Add AV perf layout tests to webkit flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=94255

Attachment 158911: Patch
https://bugs.webkit.org/attachment.cgi?id=158911&action=review

------- Additional Comments from Shadi <shadi at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158911&action=review


>> Tools/TestResultServer/static-dashboards/builders.js:59
>>  var LEGACY_BUILDER_MASTERS_TO_GROUPS = {
> 
> You need to update this as well. Actually, now that I look at it,
ChromiumWin, ChromiumMac and ChromiumLinux are missing from here as well. Mind
adding them while you're modifying this?

Added them all. I assume they are all @DEPS.

>> Tools/TestResultServer/static-dashboards/builders.js:197
>> +	return builder.indexOf('Builder') == -1
> 
> Won't this exclude "Win7 BuilderTester"? Also, this line needs a semicolon at
the end.

I submitted this assuming the new bot names "AV Linux" and "AV Win7".

>> Tools/TestResultServer/static-dashboards/builders.js:252
>> +		requestBuilderList(LAYOUT_TESTS_BUILDER_GROUPS,
isChromiumTipOfTreeAVTestRunner, CHROMIUM_PERF_AV_BUILDER_MASTER, groupName,
BuilderGroup.TOT_WEBKIT, builderGroup);
> 
> These bots currently seem to be syncing to Chromium DEPS. Is that intended?
If so, then they should be added to the "@Deps - chromium.org" group.

I had a different understanding for what @ToT chromium was. These are
definitely @Deps.