[webkit-reviews] review canceled: [Bug 92272] ProgressTracker never completes if iframe detached during parsing : [Attachment 154773] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 16 13:54:32 PDT 2012


Nate Chapin <japhet at chromium.org> has canceled Charles Reis
<creis at chromium.org>'s request for review:
Bug 92272: ProgressTracker never completes if iframe detached during parsing
https://bugs.webkit.org/show_bug.cgi?id=92272

Attachment 154773: Patch
https://bugs.webkit.org/attachment.cgi?id=154773&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
This patch cheats a bit: Instead of trying to ensure DocumentLoader does the
right thing, solve the problem more generally by adding a helper class to
FrameLoader that counts progressStarted()/progressCompleted() calls for a given
frame and makes sure they're matched before frame detach.


More information about the webkit-reviews mailing list