[webkit-reviews] review granted: [Bug 94234] [Chromium] Changing Canvas2DLayerBridge to use SkDeferredCanvas's notification client API : [Attachment 158868] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Justin Novosad
<junov at chromium.org>'s request for review:
Bug 94234: [Chromium] Changing Canvas2DLayerBridge to use SkDeferredCanvas's
notification client API
https://bugs.webkit.org/show_bug.cgi?id=94234

Attachment 158868: Patch
https://bugs.webkit.org/attachment.cgi?id=158868&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158868&action=review


R=me.  When did this roll into skia - have you checked that it shows up in the
chr->skia rev in Source/WebKit/chromium/DEPS ?

> Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.cpp:80
> +    SkDeferredCanvas* deferred = deferredCanvas();
> +    if (deferred)

FYI, you could fold the assignment into the if() if you want, since "deferred"
isn't used outside the scope of the if