[webkit-reviews] review granted: [Bug 94123] [BlackBerry] Reload valid page from Error Page keeps history ViewState and zoom. : [Attachment 158843] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Konrad Piascik
<kpiascik at rim.com>'s request for review:
Bug 94123: [BlackBerry] Reload valid page from Error Page keeps history
ViewState and zoom.
https://bugs.webkit.org/show_bug.cgi?id=94123

Attachment 158843: Patch
https://bugs.webkit.org/attachment.cgi?id=158843&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158843&action=review


> Source/WebKit/blackberry/ChangeLog:13
> +	   the user scalalbe flag if we're reloading from an error page.

scalable*

> Source/WebKit/blackberry/ChangeLog:24
> +	   new memeber variable m_shouldRestoreViewState based on the
ViewState's

member

> Source/WebKit/blackberry/Api/WebPage.cpp:1908
> -    updateViewportSize();
> +    // This checks to make sure we're not calling updateViewportSize
> +    // during WebPagePrivate::init().
> +    if (m_backingStore)
> +	   updateViewportSize();

lets move this check to within ::updateViewportSize?