[webkit-reviews] review granted: [Bug 84281] [Chromium] Schedule texture uploads based on hard-coded timer and vsync. : [Attachment 158699] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted David Reveman
<reveman at chromium.org>'s request for review:
Bug 84281: [Chromium] Schedule texture uploads based on hard-coded timer and
vsync.
https://bugs.webkit.org/show_bug.cgi?id=84281

Attachment 158699: Patch
https://bugs.webkit.org/attachment.cgi?id=158699&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158699&action=review


R=me, but the time faking stuff is due for a cleanup. It's hard to reason about
what clock different systems are using.

> Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp:155
> +    return WTF::monotonicallyIncreasingTime();

no WTF:: - monotonicallyIncreasingTime() is in the global namespace and not
overridden by anything here

you should also move the <wtf/CurrentTime.h> #include from CCFRC.h to CCFRC.cpp
- I've no idea why it would be in the header.

> Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdateController.h:58
> +    virtual double monotonicallyIncreasingTime() const;

we really should pick a new name rather than aliasing a global symbol