[webkit-reviews] review requested: [Bug 65237] [Qt] Favicons can't be changed dynamically. : [Attachment 158847] Patch

[bugzilla-daemon at webkit.org]

Pierre Rossi <pierre.rossi at gmail.com> has asked  for review:
Bug 65237: [Qt] Favicons can't be changed dynamically.
https://bugs.webkit.org/show_bug.cgi?id=65237

Attachment 158847: Patch
https://bugs.webkit.org/attachment.cgi?id=158847&action=review

------- Additional Comments from Pierre Rossi <pierre.rossi at gmail.com>
Actually that last patch was nonsense, the signal is emitted in
FrameLoaderClientQt::dispatchDidReceiveIcon, the problem is that this only gets
called again if we restart the loader when the url is changed. The difference
with other ports could stem from the fact that they don't use the IconDatabase
maybe ?