[webkit-reviews] review granted: [Bug 94216] View source doesn't interpret escape characters in hrefs. : [Attachment 158817] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Anthony Berent
<aberent at chromium.org>'s request for review:
Bug 94216: View source doesn't interpret escape characters in hrefs.
https://bugs.webkit.org/show_bug.cgi?id=94216

Attachment 158817: Patch
https://bugs.webkit.org/attachment.cgi?id=158817&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158817&action=review


Thanks!  Let's clean up the nits and then we'll be all set.

> Source/WebCore/html/HTMLViewSourceDocument.h:61
> -    int addRange(const String& source, int start, int end, const String&
className, bool isLink = false, bool isAnchor = false);
> +    int addRange(const String& source, int start, int end, const String&
className, bool isLink = false, bool isAnchor = false, const String& link =
"");

nit: const String& link = String()

This avoids a malloc by using a null string rather than an empty string.