[webkit-reviews] review denied: [Bug 93090] Web Inspector: requests filtering in network tab : [Attachment 158792] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Chadnov
<chadnov at google.com>'s request for review:
Bug 93090: Web Inspector: requests filtering in network tab
https://bugs.webkit.org/show_bug.cgi?id=93090

Attachment 158792: Patch
https://bugs.webkit.org/attachment.cgi?id=158792&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158792&action=review


> Source/WebCore/inspector/front-end/NetworkPanel.js:1072
> +	   this._highlightMatchedRequests([], false,
createPlainTextSearchRegex(""));

Let's always use ...ForSearch method for search.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1136
> +    _highlightNthMatchedRequestForSearch: function(matchedRequestIndex,
reveal, regExp)

Please remove regExp parameter here, for search it is always this._searchRegExp