[webkit-reviews] review requested: [Bug 84210] [chromium] Add tracing for active composited animations : [Attachment 158835] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 16 09:03:21 PDT 2012
vollick at chromium.org has asked for review:
Bug 84210: [chromium] Add tracing for active composited animations
https://bugs.webkit.org/show_bug.cgi?id=84210
Attachment 158835: Patch
https://bugs.webkit.org/attachment.cgi?id=158835&action=review
------- Additional Comments from vollick at chromium.org
Addressed reviewer comments, but adding r? because I reworked the patch a fair
bit. Now that CCActiveAnimations own all the information to do the tracing, it
makes no sense for that code to live in CCLayerAnimationController. This made
the patch much cleaner, but there was one catch -- in the animation controller,
when we cloned animations for the impl thread, this was often followed by an
initialization step to set up the initial run state and start time. These state
changes caused logging, but they should not have. To get around this, I made a
new clone function called cloneAndInitialize for cloning and initializing.
More information about the webkit-reviews
mailing list