[webkit-reviews] review granted: [Bug 90720] [Mac] Do not perform 8 to 16bits characters conversion when converting a WTFString to NSString/CFString : [Attachment 158731] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 90720: [Mac] Do not perform 8 to 16bits characters conversion when
converting a WTFString to NSString/CFString
https://bugs.webkit.org/show_bug.cgi?id=90720

Attachment 158731: Patch
https://bugs.webkit.org/attachment.cgi?id=158731&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=158731&action=review


r=me

> Source/WebCore/platform/text/cf/StringImplCF.cpp:153
> +	   ASSERT(!StringWrapperCFAllocator::currentString);

Seems like you should remove this ASSERT too.
CFStringCreateWithCharactersNoCopy might implement the same optimization --
now, or in the future.