[webkit-reviews] review canceled: [Bug 93872] [Qt] Replace use of internal Weak smart pointer with JSWeakObjectMap : [Attachment 158805] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 16 07:21:43 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has canceled Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 93872: [Qt] Replace use of internal Weak smart pointer with JSWeakObjectMap
https://bugs.webkit.org/show_bug.cgi?id=93872

Attachment 158805: Patch
https://bugs.webkit.org/attachment.cgi?id=158805&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158805&action=review


r=me... but you already filled that in

> Source/WebCore/bridge/qt/qt_instance.cpp:50
> +    // Deleted by GC when m_context's globalObject gets collected

Missed . though

> Source/WebCore/bridge/qt/qt_instance.cpp:67
> +    // Just us and the ref in the weakMaps left?

Why is this a question?


More information about the webkit-reviews mailing list