[webkit-reviews] review granted: [Bug 94176] [BlackBerry] Some media controls are mispositioned for dynamic live streams (HLS) : [Attachment 158696] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 16 07:20:53 PDT 2012
Antonio Gomes <tonikitoo at webkit.org> has granted Max Feil <mfeil at rim.com>'s
request for review:
Bug 94176: [BlackBerry] Some media controls are mispositioned for dynamic live
streams (HLS)
https://bugs.webkit.org/show_bug.cgi?id=94176
Attachment 158696: Patch
https://bugs.webkit.org/attachment.cgi?id=158696&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158696&action=review
r+
I have one comment. Feel free to address it or not. If you do, please reupload
the patch with pre-filled "Reviewed by Antonio Gomes" in the changelog and
commit message, and just request cq? Thanks.
> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:771
> + Length zero(0, Fixed);
I would have defined "zero" within the if where it is used.
More information about the webkit-reviews
mailing list