[webkit-reviews] review granted: [Bug 94058] [BlackBerry] [DRT] 5 tests failed for incorrect JS console message format : [Attachment 158745] patch updated

[bugzilla-daemon at webkit.org]

Yong Li <yoli at rim.com> has granted  review:
Bug 94058: [BlackBerry] [DRT] 5 tests failed for incorrect JS console message
format
https://bugs.webkit.org/show_bug.cgi?id=94058

Attachment 158745: patch updated
https://bugs.webkit.org/attachment.cgi?id=158745&action=review

------- Additional Comments from Yong Li <yoli at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=158745&action=review


> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:662
> +    printf("%s\n", newMessage.utf8().data());

I have introduced a class ReadOnlyLatinString that will give better performance
if you are sure latin1() won't lose any info and in most cases the String has a
8-bit internal buffer. But this is minor thing, especially this is only for
DRT.