[webkit-reviews] review denied: [Bug 94100] Calendar picker shows wrong date when input element has year earlier than 100 : [Attachment 158783] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 16 06:36:23 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 94100: Calendar picker shows wrong date when input element has year earlier
than 100
https://bugs.webkit.org/show_bug.cgi?id=94100

Attachment 158783: Patch
https://bugs.webkit.org/attachment.cgi?id=158783&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158783&action=review


> LayoutTests/fast/forms/date/calendar-picker-appearance-pre-100-expected.txt:9

> +TEST COMPLETE
> +PASS document.getElementById("date").value is "0002-02-03"

"TEST COMPLETE" followed by the PASS looks wrong.

You need to use jsTestIsAsync=true & finishJSTest() if you use js-test-post.js,
or need to remove js-test-post.js.

> LayoutTests/platform/chromium/TestExpectations:2494
> +BUGWK92710 : fast/forms/date/calendar-picker-appearance-pre-100.html = IMAGE
PASS

We don't need it.


More information about the webkit-reviews mailing list