[webkit-reviews] review denied: [Bug 93090] Web Inspector: requests filtering in network tab : [Attachment 158779] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Chadnov
<chadnov at google.com>'s request for review:
Bug 93090: Web Inspector: requests filtering in network tab
https://bugs.webkit.org/show_bug.cgi?id=93090

Attachment 158779: Patch
https://bugs.webkit.org/attachment.cgi?id=158779&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158779&action=review


> Source/WebCore/inspector/front-end/NetworkPanel.js:1072
> +	   this._highlightMatchedRequests([], false, "");

"" doesn't look like a regexp to me. Please annotate new methods to make sure
we catch such errors.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1106
> +	   if (regExp.test(""))

I don't think this is needed.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1155
> +		   this._toggleLargerRequests();

This should be in highlight... method because it's needed both for search and
filtering.