[webkit-reviews] review granted: [Bug 93865] Break on inline scripts blocked by CSP. : [Attachment 158774] resetting tests.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Mike West
<mkwst at chromium.org>'s request for review:
Bug 93865: Break on inline scripts blocked by CSP.
https://bugs.webkit.org/show_bug.cgi?id=93865

Attachment 158774: resetting tests.
https://bugs.webkit.org/attachment.cgi?id=158774&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158774&action=review


> Source/WebCore/inspector/Inspector.json:2817
> +		       { "name": "reason", "type": "string", "enum": [ "XHR",
"DOM", "EventListener", "exception", "CSPViolation", "other" ], "description":
"Pause reason." },

Oh, so that string was a part of the enum. Now we are violating the protocol a
tiny bit. I'll think of removing this enum declration.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:306
> +	      
this.sidebarPanes.callstack.setStatus(WebInspector.UIString("Paused on a script
blocked due to Content Security Policy directive: \"%s\".",
details.auxData.directiveText));

Please add this to the English.lproj/localizedStrings.js and you are good to
go.