[webkit-reviews] review requested: [Bug 73819] [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON : [Attachment 158769] Fixes the bug

[bugzilla-daemon at webkit.org]

Alejandro Piñeiro <apinheiro at igalia.com> has asked  for review:
Bug 73819: [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not
ROLE_PUSH_BUTTON
https://bugs.webkit.org/show_bug.cgi?id=73819

Attachment 158769: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=158769&action=review

------- Additional Comments from Alejandro Piñeiro <apinheiro at igalia.com>
(In reply to comment #15)
> (In reply to comment #14)
> > 
> > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:495
> > > > +}
> > > 
> > > I think isButton() already returns true if ariaRoleAttribute is button.
> 
> What about this comment?

True, I have simplified the check on the fuction.

> > > > Source/WebCore/accessibility/AccessibilityRenderObject.h:74
> > > > +    virtual bool isToggleButton() const;
> > > 
> > > this should probably be private
> > 
> 
> I think you wan to leave it public on AccessibilityObject, but make it
private on AccessibilityRenderObject.

Ok. Now isToggleButton is public on AccessibilityObject but private on
AccessibilityRenderObject.