[webkit-reviews] review denied: [Bug 94125] Web Inspector: enable instrumentation of platform code : [Attachment 158756] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 94125: Web Inspector: enable instrumentation of platform code
https://bugs.webkit.org/show_bug.cgi?id=94125

Attachment 158756: Patch
https://bugs.webkit.org/attachment.cgi?id=158756&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158756&action=review


Minor nits, otherwise looks good.

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:-491
> -	       InspectorInstrumentation::setTimelineAgentForOrphanEvents(0);

You should remove
InspectorInstrumentation::setTimelineAgentForOrphanEvents,
InspectorInstrumentation::threadSpecificTimelineAgentForOrphanEvents, etc. as
well

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:556
> +	   m_platformInstrumentationClientSet = m_recordStack.size();

m_platformInstrumentationClientInstalledAtStackDepth

> Source/WebCore/platform/PlatformInstrumentation.h:46
> +    virtual void willDecodeImage(const WTF::String& imageType) = 0;

Here and below drop WTF::

> Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:265
> +    if (frame.status() != ImageFrame::FrameComplete) {

You did not remove TRACE_EVENT macro / include.