[webkit-reviews] review denied: [Bug 94196] [Tests] Adding tests for multiple fields time input UI : [Attachment 158761] Patch 4

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 94196: [Tests] Adding tests for multiple fields time input UI
https://bugs.webkit.org/show_bug.cgi?id=94196

Attachment 158761: Patch 4
https://bugs.webkit.org/attachment.cgi?id=158761&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158761&action=review


Off topic: I feel we need some margin between the last field and the spin
button.

> LayoutTests/ChangeLog:18
> +	   * fast/forms/resources/time-multiple-fields-appearance.css: Added.

This should be put into fast/forms/time-multiple-fields/resources/.

> LayoutTests/ChangeLog:36
> +	   *
platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-ap
pearance-disabled-readonly-expected.png: Added.

Is this result expected? The readonly appearance is almost identical with the
normal appearance except gray spinbutton.

> LayoutTests/fast/forms/resources/time-multiple-fields-appearance.css:90
> +    x-margin-bottom: -1px;

What's x-?

> LayoutTests/platform/chromium/TestExpectations:180
> +BUGWK94196 MAC WIN :
fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readon
ly.html = IMAGE TEXT IMAGE+TEXT PASS
> +BUGWK94196 MAC WIN :
fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.
html = IMAGE TEXT IMAGE+TEXT PASS
> +BUGWK94196 MAC WIN :
fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html =
IMAGE TEXT IMAGE+TEXT PASS

Need MISSING.