[webkit-reviews] review denied: [Bug 93742] HTML Parser should produce 8bit substrings for inline style and script elements : [Attachment 158598] Updated Patch using OS(DARWIN) and intrinsics

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied  review:
Bug 93742: HTML Parser should produce 8bit substrings for inline style and
script elements
https://bugs.webkit.org/show_bug.cgi?id=93742

Attachment 158598: Updated Patch using OS(DARWIN) and intrinsics
https://bugs.webkit.org/attachment.cgi?id=158598&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158598&action=review


>> Source/WTF/wtf/text/ASCIIFastPath.h:121
>> +	const UChar* alignedEnd = reinterpret_cast<const
UChar*>((reinterpret_cast<const uintptr_t>(source + length))&~sourceLoadMask);
> 
> Any way to get rid of the reinterpret_cast?
> Coding style: spaces around the "&" operator.

If length so small that you do not pass the next 16bytes alignment, alignedEnd
is invalid (< source).