[webkit-reviews] review requested: [Bug 45118] Update TypedArrays to throw RangeError or similar instead of INDEX_SIZE_ERR : [Attachment 158676] updated patch to build on mac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 15 18:10:46 PDT 2012


arno. <arno at renevier.net> has asked  for review:
Bug 45118: Update TypedArrays to throw RangeError or similar instead of
INDEX_SIZE_ERR
https://bugs.webkit.org/show_bug.cgi?id=45118

Attachment 158676: updated patch to build on mac
https://bugs.webkit.org/attachment.cgi?id=158676&action=review

------- Additional Comments from arno. <arno at renevier.net>
I tried to separate JSArrayBufferViewHelper and JSTypedArrayBufferViewHelper to
not have an unneeeded ooutOfRangeLengthAndOffset static variable. But it made a
lot of modifications, and at the end, I could not share the variable
tooLargeSize and had to duplicate it anyway. So the best way I could find to
fix the build failure on mac is to duplicate the error string. Also, v8 part of
the patch is updated to build on top of bug #93792


More information about the webkit-reviews mailing list