[webkit-reviews] review granted: [Bug 94119] VoidCallback should not be a special snowflake : [Attachment 158654] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 94119: VoidCallback should not be a special snowflake
https://bugs.webkit.org/show_bug.cgi?id=94119

Attachment 158654: Patch
https://bugs.webkit.org/attachment.cgi?id=158654&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158654&action=review


LGTM.  Except the XCode oddity of course.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:1963
> +		7C522D4C15B478B2009B7C95 /* (null) in Headers */ = {isa =
PBXBuildFile; settings = {ATTRIBUTES = (Private, ); }; };

This looks wrong.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:23634
> +				7C522D4C15B478B2009B7C95 /* (null) in Headers
*/,

This also looks wrong.